Skip to content

trigger can be string[] or string #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2016

Conversation

eyn
Copy link
Contributor

@eyn eyn commented Jun 13, 2016

When using OverlayTrigger the trigger property takes both a string or an array of strings for multiple triggers.

@christhomas
Copy link
Contributor

Thanks eyn, I'll look at this shortly, what I find amazing is that the typescript definitions were so old that I thought nobody was using them except me :P then the second I make an effort to put them on github and give people the ability to give patches, I get a bunch of them in a short timeframe.

Amazing stuff, keep those improvements coming, I'll pretty much accept everything cause I think right now we have a lot of things to improve upon

@christhomas christhomas merged commit de40a67 into react-bootstrap:master Jun 13, 2016
@christhomas
Copy link
Contributor

ok, I looked, it was simple, I've published/updated the new npm module:
react-bootstrap-typescript@0.0.6

@eyn eyn deleted the fix-overlaytrigger-defn branch June 13, 2016 10:35
@eyn
Copy link
Contributor Author

eyn commented Jun 13, 2016

Thanks - will send stuff over as I come across issues.

Cheers,

James

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants